Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom md files for package documentation #43497

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

azinneera
Copy link
Contributor

@azinneera azinneera commented Oct 20, 2024

Purpose

Introduce README.md as the default documentation file for packages.

Fixes #42981

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@azinneera azinneera marked this pull request as draft October 20, 2024 17:17
@azinneera azinneera force-pushed the prj_api_readme_new branch 6 times, most recently from 6a0fc95 to 03ef126 Compare November 13, 2024 12:38
@azinneera azinneera marked this pull request as ready for review November 13, 2024 12:41
@azinneera azinneera force-pushed the prj_api_readme_new branch 3 times, most recently from c50f51c to dac4922 Compare November 17, 2024 08:28
@azinneera azinneera force-pushed the prj_api_readme_new branch 2 times, most recently from b583b3c to 543a779 Compare November 17, 2024 17:26
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 70 lines in your changes missing coverage. Please review.

Project coverage is 77.47%. Comparing base (e8b5bc5) to head (fb27ea2).
Report is 257 commits behind head on master.

Files with missing lines Patch % Lines
...o/ballerina/projects/internal/ManifestBuilder.java 82.67% 11 Missing and 11 partials ⚠️
...rc/main/java/io/ballerina/cli/cmd/CommandUtil.java 61.53% 15 Missing and 5 partials ⚠️
...ballerina/projects/internal/model/PackageJson.java 33.33% 6 Missing ⚠️
...java/io/ballerina/projects/internal/BalaFiles.java 86.48% 3 Missing and 2 partials ⚠️
...rc/main/java/io/ballerina/cli/cmd/PushCommand.java 84.61% 2 Missing ⚠️
...rc/main/java/io/ballerina/projects/BalaWriter.java 94.59% 0 Missing and 2 partials ⚠️
...in/java/io/ballerina/projects/PackageReadmeMd.java 90.47% 2 Missing ⚠️
...ava/io/ballerina/tools/diagnostics/Diagnostic.java 60.00% 1 Missing and 1 partial ⚠️
...allerinalang/docgen/generator/model/ModuleDoc.java 33.33% 1 Missing and 1 partial ⚠️
.../main/java/io/ballerina/projects/ModuleConfig.java 66.66% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43497      +/-   ##
============================================
- Coverage     77.55%   77.47%   -0.09%     
+ Complexity    58752    58512     -240     
============================================
  Files          3448     3434      -14     
  Lines        219728   218711    -1017     
  Branches      28922    28918       -4     
============================================
- Hits         170411   169443     -968     
+ Misses        39921    39874      -47     
+ Partials       9396     9394       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azinneera azinneera changed the title [WIP] Support custom md files for package documentation Support custom md files for package documentation Nov 18, 2024
@azinneera azinneera merged commit b517ec9 into ballerina-platform:master Nov 18, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Add README.md as the primary documentation file for library packages
2 participants