Implement mapping semtype in runtime #42956
Closed
Commits on Jul 22, 2024
Commits on Jul 23, 2024
-
Use new api in CompilerTypeTestApi Extract out the which semtype implementation used for tests Implement semtype tests
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Optimize TypeChecker:basicType
Avoid doing a `instanceOf` on a abstract type (which trigger a full type check) and instead use a virtual function that create the basic type which should be cheaper
-
-
Fix hash and equals for semtypes
Memoization depends on hash and equals. Otherwise we create duplicate memos for equal types
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Refactor type checker with "widenedType"
Widened type for basic types is the basic type where as for other types it is contextually expected type (not the actual shape of the value). This is to avoid the overhead of having to create singleton types for each basic type value
-
-
-
-
-
-
-
-
-
-
Due to reasons that are not entierly clear to me when we run all the unit tests some how types from `record_project_closed_rec_equiv` to clashed with types defined in other unit tests. As a temperary workaround I introduced a new package name for this.
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.