Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse the existing semtype port tests to test the runtime semtype implementation #42841

Conversation

heshanpadmasiri
Copy link
Member

Purpose

Extend #42794 to use existing type semtype port tests

Fixes #42814

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 73.42304% with 316 lines in your changes missing coverage. Please review.

Project coverage is 77.34%. Comparing base (843bb40) to head (505006f).
Report is 15 commits behind head on nutcracker.

Files Patch % Lines
...untime/internal/types/semtype/BBooleanSubType.java 25.00% 37 Missing and 11 partials ⚠️
...runtime/internal/types/semtype/BStringSubType.java 48.27% 38 Missing and 7 partials ⚠️
...untime/internal/types/semtype/BDecimalSubType.java 43.75% 27 Missing and 9 partials ⚠️
...na/runtime/internal/types/semtype/BIntSubType.java 78.20% 22 Missing and 12 partials ⚠️
...a/io/ballerina/runtime/api/types/semtype/Core.java 76.64% 20 Missing and 12 partials ⚠️
.../runtime/internal/types/semtype/BFloatSubType.java 58.90% 18 Missing and 12 partials ⚠️
...erina/runtime/api/types/semtype/SemTypeHelper.java 0.00% 29 Missing ⚠️
.../internal/types/semtype/EnumerableSubtypeData.java 86.51% 7 Missing and 5 partials ⚠️
...lerina/runtime/internal/types/BSemTypeWrapper.java 69.69% 10 Missing ⚠️
...ballerina/runtime/internal/types/BIntegerType.java 82.35% 5 Missing and 1 partial ⚠️
... and 13 more
Additional details and impacted files
@@               Coverage Diff                @@
##             nutcracker   #42841      +/-   ##
================================================
- Coverage         77.38%   77.34%   -0.04%     
- Complexity        52454    52722     +268     
================================================
  Files              2997     3020      +23     
  Lines            208035   209228    +1193     
  Branches          27222    27438     +216     
================================================
+ Hits             160987   161831     +844     
- Misses            38189    38451     +262     
- Partials           8859     8946      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lochana-chathura lochana-chathura added Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Area/SemtypeIntegration Issue related to integrating semtype engine labels Jun 28, 2024
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jul 15, 2024
@heshanpadmasiri heshanpadmasiri force-pushed the feat/runtime-type-test branch 2 times, most recently from 625bb07 to 968a5a5 Compare July 22, 2024 03:49
Copy link

github-actions bot commented Aug 8, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 8, 2024
@heshanpadmasiri
Copy link
Member Author

Closed in favour of #43279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemtypeIntegration Issue related to integrating semtype engine Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants