Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update netty-codec-http version #42694

Conversation

chiranSachintha
Copy link
Member

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@chiranSachintha chiranSachintha merged commit f29b411 into ballerina-platform:ballerina-1.2.x May 6, 2024
7 checks passed
Copy link
Contributor

@nipunayf nipunayf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump this to .109 [1] instead? It appears that there is a small vulnerability with .108 [2]?

[1] https://mvnrepository.com/artifact/io.netty/netty-codec-http/4.1.109.Final
[2] https://security.snyk.io/vuln/SNYK-JAVA-IONETTY-6483812

@chiranSachintha
Copy link
Member Author

Can we bump this to .109 [1] instead? It appears that there is a small vulnerability with .108 [2]?

[1] https://mvnrepository.com/artifact/io.netty/netty-codec-http/4.1.109.Final [2] https://security.snyk.io/vuln/SNYK-JAVA-IONETTY-6483812

If there are any high severity vulnerability, I will update to the latest version. If not, I will stick with version .108.

@TharmiganK
Copy link
Contributor

TharmiganK commented May 6, 2024

I think you have to update the wso2 transport also to the latest version here:

dist 'org.wso2.transport.http:org.wso2.transport.http.netty:6.3.48'

Wso2 transport also has netty dependency

Also it is safer to update all the netty packages to 4.1.108.Final rather than updating the vulnerable ones. The compatible tcnative version is 2.0.65.Final

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants