Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved diagnostic rendering #42236

Draft
wants to merge 55 commits into
base: master
Choose a base branch
from

Commits on Apr 9, 2024

  1. Configuration menu
    Copy the full SHA
    49316b7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0e214c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    61bc9fc View commit details
    Browse the repository at this point in the history
  4. Filter duplicate diagnostics

    RadCod3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    affe957 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5585a3b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6399787 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a43a4ff View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f5477c0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c79a1c8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    662b8df View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    bd77867 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ac7c15f View commit details
    Browse the repository at this point in the history
  13. Clean up

    RadCod3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    05373ed View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    837a200 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5cf9400 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    5b43f9c View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    ea57515 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    3d3a6f0 View commit details
    Browse the repository at this point in the history
  19. Update jline version for test compatibility

    jline 3.25.1 which is the latest at time of writing, breaks most of our
    test cases related ballerina shell. After testing around it seems that
    this is caused by the dumbterminal. Even though tests failed the bal
    shell command seems to work as usual. There is no mention of this issue
    on jline's issues and I was not able to reproduce it in a sample java
    project. The version bump I needed to access jansi from within jline
    happened in jline 3.25.0, therefore instead of 3.25.1 I changed it back
    to 3.25.0 until we find a way to change our test cases or jline's
    future updates.
    RadCod3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    ec2b328 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    163df5f View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    e3dfaaf View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    8eb0560 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    c6d4865 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    710f66d View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    151f957 View commit details
    Browse the repository at this point in the history
  26. Remove unused imports

    RadCod3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    b061f95 View commit details
    Browse the repository at this point in the history
  27. Add newline

    RadCod3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    0f86532 View commit details
    Browse the repository at this point in the history
  28. Fix testerina windows test

    RadCod3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    4fc62c6 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    bb5bc5e View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    b3ac8ab View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    95f0cd2 View commit details
    Browse the repository at this point in the history
  32. Improve truncate function

    RadCod3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    4c4d8fb View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    89ab5b8 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    36a762e View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    0fc64f0 View commit details
    Browse the repository at this point in the history
  36. Update tests

    RadCod3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    03d4b31 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    3a9a080 View commit details
    Browse the repository at this point in the history
  38. Add newlines and more tests

    RadCod3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8d5cfb1 View commit details
    Browse the repository at this point in the history
  39. Address code review comments

    RadCod3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    32e2373 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    c67a40d View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    bb72797 View commit details
    Browse the repository at this point in the history
  42. Refactor truncation logic, rename function name

    Current implementation started truncating before the line is equal to
    the max length.
    RadCod3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a81b064 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Configuration menu
    Copy the full SHA
    a4ece31 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Address code review comments

    RadCod3 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    7cf46e5 View commit details
    Browse the repository at this point in the history
  2. Move logic from CompileTask to AnnotateDiagnostics

    Switched from using only static methods to an instance based approach
    for AnnotateDiagnostics, making the code in CompileTask more readable.
    RadCod3 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ce37ed7 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Address suggestions made at code review

    Shifted from string concatenation to string builders. Combined some
    common login in DiagnosticAnnotation for when lines are hidden and not
    hidden in the multi-line diagnostic case. Also made the amount of lines
    to be shown before we start hiding lines configurable.
    RadCod3 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    998bfd3 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    b903b1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    85d3c98 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a66495b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7f4f3ed View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Fix bug found in code review

    RadCod3 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2ede880 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4129911 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Configuration menu
    Copy the full SHA
    fda2128 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. WIP diagnostic area text wrap

    RadCod3 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    12e70f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Apply suggestions from code review

    Co-authored-by: Felix Schnabel <[email protected]>
    gimantha and Shadow-Devil authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    ca8c192 View commit details
    Browse the repository at this point in the history