Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exiting bal test when a program has listeners and running workers/async functions #41210

Merged

Conversation

Nadeeshan96
Copy link
Contributor

@Nadeeshan96 Nadeeshan96 commented Aug 15, 2023

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

$title
Fixes #41213
Fixes #40934

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

PR also contains changes from #41005.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 75.42% and project coverage change: -0.01% ⚠️

Comparison is base (5965e35) 76.34% compared to head (f7bb8b9) 76.33%.
Report is 70 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #41210      +/-   ##
============================================
- Coverage     76.34%   76.33%   -0.01%     
- Complexity    52351    52382      +31     
============================================
  Files          2868     2868              
  Lines        197879   197965      +86     
  Branches      25720    25746      +26     
============================================
+ Hits         151062   151121      +59     
- Misses        38494    38508      +14     
- Partials       8323     8336      +13     
Files Changed Coverage Δ
...ler/api/symbols/resourcepath/util/PathSegment.java 100.00% <ø> (ø)
...llerinalang/compiler/bir/codegen/JvmConstants.java 100.00% <ø> (ø)
...lerinalang/compiler/bir/codegen/JvmPackageGen.java 89.16% <ø> (-0.27%) ⬇️
...rinalang/compiler/bir/emit/InstructionEmitter.java 39.45% <0.00%> (-0.88%) ⬇️
...rg/ballerinalang/langserver/rename/RenameUtil.java 81.70% <0.00%> (-1.49%) ⬇️
...api/impl/symbols/BallerinaPathParameterSymbol.java 69.09% <65.00%> (+17.87%) ⬆️
...o/ballerina/compiler/api/impl/ReferenceFinder.java 83.33% <65.21%> (-0.67%) ⬇️
.../compiler/bir/codegen/methodgen/InitMethodGen.java 96.60% <73.68%> (-1.49%) ⬇️
.../io/ballerina/compiler/api/impl/SymbolFactory.java 90.82% <81.81%> (+0.11%) ⬆️
...pi/impl/symbols/BallerinaResourceMethodSymbol.java 85.41% <87.50%> (+0.63%) ⬆️
... and 11 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nadeeshan96 Nadeeshan96 added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Aug 16, 2023
@Nadeeshan96 Nadeeshan96 added this to the 2201.8.0 milestone Aug 16, 2023
@Nadeeshan96 Nadeeshan96 marked this pull request as ready for review August 16, 2023 01:58
@Nadeeshan96 Nadeeshan96 requested review from gabilang, HindujaB and warunalakshitha and removed request for hasithaa and sameerajayasoma August 16, 2023 01:59
@Nadeeshan96 Nadeeshan96 changed the title Fix bal test a program with listeners and running workers Fix exiting bal test when a program has listeners and running workers/async functions Aug 16, 2023
@Nadeeshan96
Copy link
Contributor Author

When there is a test failure, still bal test hangs, need to fix that and add a test.

@Nadeeshan96
Copy link
Contributor Author

Nadeeshan96 commented Aug 17, 2023

Merged changes from #41005.

When there is a test failure, still bal test hangs, need to fix that and add a test.

This is fixed and a test was added for the case where a test fails in bal test.

gabilang
gabilang previously approved these changes Aug 18, 2023
Copy link
Contributor

@gabilang gabilang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HindujaB
HindujaB previously approved these changes Aug 18, 2023
Copy link
Contributor

@HindujaB HindujaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nadeeshan96 Nadeeshan96 dismissed stale reviews from HindujaB and gabilang via 1751f36 August 20, 2023 13:13
Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nadeeshan96
Copy link
Contributor Author

Nadeeshan96 commented Aug 20, 2023

After I synched the PR with the master ProfilerTest failed due to assertion in "○ Instrumented function count: " showing the now the instrumented functions is less than 1 from before. Hence loosened the assertion with f7bb8b9. Created #41250 to verify the test outputs of the Profiler.

@Nadeeshan96 Nadeeshan96 merged commit 2c9afc6 into ballerina-platform:master Aug 20, 2023
15 of 17 checks passed
@Nadeeshan96 Nadeeshan96 deleted the master-fix-test-execution branch August 21, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
4 participants