Support large list and mapping constructors #41017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a029002
Fixed the bug found when running testBooleanFreeze test.
Fixed the bug found when running TypeTestExprTest tests.
Fixed the bug found when running SealedArraysOfArraysTest tests.
This is done to fix the failing SimpleQueryExpressionWithDefinedTypeTest.
Nadeeshan96
added
the
Team/jBallerina
This is done to fix the failing testXMLCycleError langlib test.
This is done to fix the failing CollectClauseTest tests.
gabilang
reviewed
Aug 14, 2023
...lerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmInstructionGen.java
Outdated
Show resolved
Hide resolved
gabilang
reviewed
Aug 14, 2023
...ina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/model/BIRAbstractInstruction.java
Show resolved
Hide resolved
gabilang
previously approved these changes
Aug 14, 2023
...allerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/emit/InstructionEmitter.java
Outdated
Show resolved
Hide resolved
tests/ballerina-test-utils/src/main/java/org/ballerinalang/test/BRunUtil.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java
Show resolved
Hide resolved
HindujaB
reviewed
Aug 15, 2023
...lerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmInstructionGen.java
Show resolved
Hide resolved
...rc/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java
Outdated
Show resolved
Hide resolved
warunalakshitha
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title
Fixes #36440
Fixes #41065
Fixes #33534
Fixes #41134
Approach
Samples
Remarks
Draft PR sent to check the code coverage and whether the tests are passing with the lowest thresholds: #41181.
Performance comparison in code compilation and execution with and without these changes
Tested code (click to expand)
Performance tested with hyperfine with 100 runs (with additional 10 warmup runs) with no statistical outliers.
bal build --offlinejava -jarCheck List