-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support constant byte array literal #40979
Support constant byte array literal #40979
Conversation
Symbol enter revamp
…ng into byte-array-literal
…ng into byte-array-literal
Support list-constructor-expr
...lerina-unit-test/src/test/resources/test-src/types/constant/constant-assignment-negative.bal
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Outdated
Show resolved
Hide resolved
...er/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/parser/BLangNodeBuilder.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/ConstantTypeChecker.java
Outdated
Show resolved
Hide resolved
Since we know the constant value at compile-time, we should support below case
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #40979 +/- ##
=============================================
+ Coverage 0.00% 76.39% +76.39%
- Complexity 0 52119 +52119
=============================================
Files 9 2858 +2849
Lines 35 195968 +195933
Branches 0 25401 +25401
=============================================
+ Hits 0 149717 +149717
- Misses 35 37952 +37917
- Partials 0 8299 +8299
☔ View full report in Codecov by Sentry. |
e1983a5
to
7000cfb
Compare
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
With this commit this issue could be fixed. Could you pls add those changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
Fixes #40536
Fixes #37423
Approach
Samples
Remarks
Check List