-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE in SemanticModel.typeOf()
API for resource path access action nodes
#40026
Fix NPE in SemanticModel.typeOf()
API for resource path access action nodes
#40026
Conversation
...piler-api-test/src/test/java/io/ballerina/semantic/api/test/typeof/TypeOfRegressionTest.java
Outdated
Show resolved
Hide resolved
...mpiler-api-test/src/test/resources/test-src/regression-tests/typeof_resource_path_action.bal
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use the below file to write the test case.
https://github.com/ballerina-platform/ballerina-lang/blob/master/tests/ballerina-compiler-api-test/src/test/resources/test-src/actions/resource_access_action.bal
...piler-api-test/src/test/java/io/ballerina/semantic/api/test/typeof/TypeOfRegressionTest.java
Outdated
Show resolved
Hide resolved
...piler-api-test/src/test/java/io/ballerina/semantic/api/test/typeof/TypeOfRegressionTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #40026 +/- ##
============================================
+ Coverage 76.22% 76.96% +0.73%
- Complexity 51891 57036 +5145
============================================
Files 2857 3393 +536
Lines 195610 214724 +19114
Branches 25319 29302 +3983
============================================
+ Hits 149113 165266 +16153
- Misses 38229 40555 +2326
- Partials 8268 8903 +635
☔ View full report in Codecov by Sentry. |
...iler/ballerina-lang/src/main/java/io/ballerina/compiler/api/impl/BallerinaSemanticModel.java
Show resolved
Hide resolved
...mpiler-api-test/src/test/resources/test-src/regression-tests/typeof_resource_path_action.bal
Outdated
Show resolved
Hide resolved
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
Closed PR due to inactivity for more than 18 days. |
@sanjana please work on the suggestion and get this merged soon |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
Closed PR due to inactivity for more than 18 days. |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
1321b74
to
71aa765
Compare
71aa765
to
bf52ee4
Compare
...mpiler-api-test/src/test/resources/test-src/regression-tests/typeof_resource_path_action.bal
Outdated
Show resolved
Hide resolved
tests/ballerina-compiler-api-test/src/test/resources/test-src/testproject/client.bal
Outdated
Show resolved
Hide resolved
tests/ballerina-compiler-api-test/src/test/resources/test-src/testproject/client.bal
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
Closed PR due to inactivity for more than 18 days. |
Purpose
Fixes #39070
Approach
Samples
Remarks
Check List