Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in SemanticModel.typeOf() API for resource path access action nodes #40026

Merged
merged 7 commits into from
Aug 9, 2023

Conversation

sanjana
Copy link
Contributor

@sanjana sanjana commented Mar 29, 2023

Purpose

$title

Fixes #39070

Approach

Samples

Remarks

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@sanjana sanjana added Team/CompilerFETools Semantic API, Formatter, Shell Area/SemanticAPI Semantic API Related Issues #Compiler labels Mar 29, 2023
Copy link
Contributor

@LakshanWeerasinghe LakshanWeerasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.73% 🎉

Comparison is base (bd82c28) 76.22% compared to head (de76ba7) 76.96%.
Report is 260 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40026      +/-   ##
============================================
+ Coverage     76.22%   76.96%   +0.73%     
- Complexity    51891    57036    +5145     
============================================
  Files          2857     3393     +536     
  Lines        195610   214724   +19114     
  Branches      25319    29302    +3983     
============================================
+ Hits         149113   165266   +16153     
- Misses        38229    40555    +2326     
- Partials       8268     8903     +635     
Files Changed Coverage Δ
...na/compiler/internal/parser/tree/STActionNode.java 50.00% <ø> (ø)
...ernal/parser/tree/STAnnotAccessExpressionNode.java 58.82% <ø> (ø)
...ernal/parser/tree/STAnnotationAttachPointNode.java 75.00% <ø> (ø)
...ernal/parser/tree/STAnnotationDeclarationNode.java 69.56% <ø> (ø)
...ompiler/internal/parser/tree/STAnnotationNode.java 88.23% <ø> (ø)
...parser/tree/STAnonymousFunctionExpressionNode.java 50.00% <ø> (ø)
...ler/internal/parser/tree/STArrayDimensionNode.java 70.58% <ø> (ø)
...nternal/parser/tree/STArrayTypeDescriptorNode.java 81.25% <ø> (ø)
...nternal/parser/tree/STAssignmentStatementNode.java 72.22% <ø> (ø)
...er/internal/parser/tree/STAsyncSendActionNode.java 70.58% <ø> (ø)
... and 290 more

... and 781 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented May 6, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label May 6, 2023
@github-actions
Copy link

Closed PR due to inactivity for more than 18 days.

@pcnfernando
Copy link
Member

@sanjana please work on the suggestion and get this merged soon

@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jun 10, 2023
@github-actions
Copy link

Closed PR due to inactivity for more than 18 days.

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jul 6, 2023
@pcnfernando pcnfernando removed the Stale label Jul 7, 2023
pcnfernando
pcnfernando previously approved these changes Jul 12, 2023
Copy link
Member

@pcnfernando pcnfernando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jul 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Aug 3, 2023
@pcnfernando pcnfernando merged commit 4af6439 into ballerina-platform:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemanticAPI Semantic API Related Issues #Compiler Team/CompilerFETools Semantic API, Formatter, Shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NPE in semanticModel.typeOf() API on resource path access action
6 participants