Revert "Consider on-fail as an execution branch when possible failure is reached"

[pcnfernando]

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

Relates to #39756
Will have to reopen #38530

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• [] Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[chiranSachintha]

If we revert this PR, we will be allowing these kinds of scenarios in the 4.1 release. Although it is acceptable because we intend to permit scenarios that were previously disallowed, my concern is about when we will disallow them again in a future version. Will it be in version 4.2 or 5.0? If we make this change in version 4.2, it will be a breaking change that affects version 4.1.
@gimantha @hasithaa

[pcnfernando]

The complete fix will be sent as part of 2201.5.0 which is targeted end of this month.

[codecov]

Codecov Report

Patch coverage: 81.81% and project coverage change: -0.01 ⚠️

Comparison is base (a16230a) 76.94% compared to head (2617a0e) 76.93%.

Additional details and impacted files

@@              Coverage Diff               @@
##             2201.4.x   #39847      +/-   ##
==============================================
- Coverage       76.94%   76.93%   -0.01%     
- Complexity      53709    53715       +6     
==============================================
  Files            3329     3330       +1     
  Lines          200163   200204      +41     
  Branches        25639    25645       +6     
==============================================
+ Hits           154014   154032      +18     
- Misses          37768    37790      +22     
- Partials         8381     8382       +1     

Impacted Files	Coverage Δ
...rc/main/java/io/ballerina/cli/utils/BuildTime.java	100.00% <ø> (ø)
...ballerinalang/debugadapter/utils/PackageUtils.java	68.64% <40.00%> (-6.59%)	⬇️
...gayal.plugins.combined/CombinedCompilerPlugin.java	72.72% <72.72%> (ø)
...c/main/java/io/ballerina/cli/task/CompileTask.java	86.36% <100.00%> (+3.93%)	⬆️
...java/io/ballerina/projects/PackageCompilation.java	92.22% <100.00%> (+0.08%)	⬆️
.../compiler/semantics/analyzer/DataflowAnalyzer.java	89.46% <100.00%> (-0.20%)	⬇️

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.