Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider on-fail as an execution branch when possible failure is reached #38828

Merged
merged 8 commits into from
Jan 27, 2023

Conversation

pcnfernando
Copy link
Member

Purpose

$subject
Fixes #38530

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@pcnfernando pcnfernando added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Nov 28, 2022
@pcnfernando pcnfernando marked this pull request as ready for review November 28, 2022 13:32
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 77.28% // Head: 76.69% // Decreases project coverage by -0.59% ⚠️

Coverage data is based on head (8dfe9ed) compared to base (cc00622).
Patch coverage: 82.94% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #38828      +/-   ##
============================================
- Coverage     77.28%   76.69%   -0.59%     
+ Complexity    69443    53517   -15926     
============================================
  Files          3518     3351     -167     
  Lines        250028   200583   -49445     
  Branches      38481    25980   -12501     
============================================
- Hits         193228   153838   -39390     
+ Misses        47444    38089    -9355     
+ Partials       9356     8656     -700     
Impacted Files Coverage Δ
.../providers/ConvertToQueryExpressionCodeAction.java 87.37% <50.00%> (-3.54%) ⬇️
...rs/createvar/CreateVariableWithTypeCodeAction.java 78.36% <67.27%> (-8.94%) ⬇️
...oviders/context/InvocationNodeContextProvider.java 83.13% <83.33%> (-6.41%) ⬇️
.../compiler/semantics/analyzer/DataflowAnalyzer.java 89.12% <100.00%> (-2.06%) ⬇️
...ction/providers/changetype/TypeCastCodeAction.java 76.05% <100.00%> (+0.15%) ⬆️
.../providers/createvar/CreateVariableCodeAction.java 93.00% <100.00%> (-1.90%) ⬇️
.../langserver/completions/util/SnippetGenerator.java 99.50% <100.00%> (+20.02%) ⬆️
...ngserver/completions/util/ContextTypeResolver.java 0.00% <0.00%> (-80.46%) ⬇️
...rg/ballerinalang/testerina/core/TestProcessor.java 33.83% <0.00%> (-56.37%) ⬇️
.../ballerina/compiler/api/impl/util/SymbolUtils.java 21.05% <0.00%> (-53.95%) ⬇️
... and 758 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Dec 31, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Jan 3, 2023
@gimantha gimantha removed the Stale label Jan 4, 2023
@gimantha gimantha reopened this Jan 4, 2023
@pcnfernando pcnfernando added this to the 2201.4.0 milestone Jan 10, 2023
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Use of on fail can lead to use of an uninitilized variable at runtime
2 participants