-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ambiguous target types with cloneWithType
and fromJsonWithType
#37622
Merged
warunalakshitha
merged 17 commits into
ballerina-platform:master
from
Nadeeshan96:master-36968-any-first-match
Sep 21, 2022
Merged
Allow ambiguous target types with cloneWithType
and fromJsonWithType
#37622
warunalakshitha
merged 17 commits into
ballerina-platform:master
from
Nadeeshan96:master-36968-any-first-match
Sep 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadeeshan96
added
the
Team/jBallerina
All the issues related to BIR, JVM backend code generation and runtime
label
Sep 5, 2022
Nadeeshan96
requested review from
warunalakshitha,
sameerajayasoma and
hasithaa
as code owners
September 5, 2022 04:34
Codecov Report
@@ Coverage Diff @@
## master #37622 +/- ##
============================================
- Coverage 74.78% 72.08% -2.70%
+ Complexity 50638 48948 -1690
============================================
Files 3346 3346
Lines 194612 194566 -46
Branches 25545 25533 -12
============================================
- Hits 145537 140255 -5282
- Misses 40684 46388 +5704
+ Partials 8391 7923 -468
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gabilang
reviewed
Sep 7, 2022
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/TypeConverter.java
Show resolved
Hide resolved
gabilang
reviewed
Sep 7, 2022
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/JsonInternalUtils.java
Outdated
Show resolved
Hide resolved
Nadeeshan96
force-pushed
the
master-36968-any-first-match
branch
from
September 8, 2022 10:48
66d1617
to
c6a5530
Compare
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/TypeConverter.java
Show resolved
Hide resolved
warunalakshitha
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title
Same behaviour is also applied for
convertJSON
method which is used inio.ballerina.runtime.api.utils.JsonUtils
Fixes #36986
Approach
Samples
Remarks
Also fixed float to decimal conversion. Java API suggests to use
valueOf
method to create a javaBigDecimal
using javaDouble
.Check List