Implement pixel history for dual source output and blend src/dest on Vulkan #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, no backend sets this, and it is not displayed.
Currently, no backend sets them, and they are not displayed.
The first one is a simply a typo. The second one seems to be an unnecessary value that doesn't make sense (as blend factors are ignored when blendEnable is false, and setting the source color blend factor to the destination color seems like an uncommon situation (the equivalent to blendEnable being false is source = 1, dest = 0). This does not seem to be a driver bug, as the commit that added it (5043898) does not mention that nor does it seem to work around other driver bugs. The third one is that VulkanDebugManager::PixelHistoryCopyPixel was declared but never defined. VulkanPixelHistoryCallback::CopyImagePixel serves the same purpose.
Before, the buffer could be overrun, which could result in anything from garbage data to the GPU device being lost to segfaults. Now, correct data is gathered. We can't know in advance how many primitives will hit the targetted pixel, so it's not possible to create the buffer until after our first pass for each events (fortunately we do know the number of events in advance). It is possible that we don't need a larger buffer, though, in which case the original one can be re-used.
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split from #3003; depends on (and includes a copy of) #3009.
This PR implements getting the dual source output and the blend source/destination components under Vulkan. It also fixes a crash when a very large number of primitives hit the same fragment in a single draw call (but there are also few draw calls overall), which is an unlikely situation in practice but did occur in some of my tests (not part of this PR).