Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pixel History columns for dual source output and blend src/dest on Vulkan #3003

Closed
wants to merge 18 commits into from

Commits on Jul 28, 2023

  1. Create pixel history shader out 2 variable

    Currently, no backend sets this, and it is not displayed.
    w-pearson committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    ccccb9a View commit details
    Browse the repository at this point in the history
  2. Create pixel history blend source and blend dest variables

    Currently, no backend sets them, and they are not displayed.
    w-pearson committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    8104d26 View commit details
    Browse the repository at this point in the history
  3. Blend pixel history widget background color with selection color

    Before, if a row was selected, the color was completely replaced, which
    makes the color preview column completely useless for that row.
    
    This change also fixes some inconsistencies with how the selection hover
    works on tree widgets; previously part of the row was not highlighted.
    w-pearson committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    5df9762 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    70b412d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    33f4b4b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c10467e View commit details
    Browse the repository at this point in the history
  7. Create pixel history tex before column

    This is already implemented by all backends, but did not get displayed
    beforehand. This column is not visible by default.
    w-pearson committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    0605594 View commit details
    Browse the repository at this point in the history
  8. Create pixel history shader out 2 column

    This has not yet been implemented by any backends, not is the column
    visible by default.
    w-pearson committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    551f147 View commit details
    Browse the repository at this point in the history
  9. Create pixel history blend source and blend dest columns

    They have not yet been implemented by any backends, not are the columns
    visible by default.
    w-pearson committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2098868 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3040f8c View commit details
    Browse the repository at this point in the history
  11. Clean up 3 small non-behavioral issues with Vulkan pixel history

    The first one is a simply a typo.
    
    The second one seems to be an unnecessary value that doesn't make sense
    (as blend factors are ignored when blendEnable is false, and setting the
    source color blend factor to the destination color seems like an
    uncommon situation (the equivalent to blendEnable being false is
    source = 1, dest = 0). This does not seem to be a driver bug, as
    the commit that added it (5043898) does
    not mention that nor does it seem to work around other driver bugs.
    
    The third one is that VulkanDebugManager::PixelHistoryCopyPixel was
    declared but never defined. VulkanPixelHistoryCallback::CopyImagePixel
    serves the same purpose.
    w-pearson committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7ec39b9 View commit details
    Browse the repository at this point in the history
  12. Fix undersized buffer for Vulkan pixel history with many fragments

    Before, the buffer could be overrun, which could result in anything from
    garbage data to the GPU device being lost to segfaults. Now, correct
    data is gathered.
    
    We can't know in advance how many primitives will hit the targetted
    pixel, so it's not possible to create the buffer until after our first
    pass for each events (fortunately we do know the number of events in
    advance). It is possible that we don't need a larger buffer, though,
    in which case the original one can be re-used.
    w-pearson committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b57b488 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a3d23a3 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f6fed2b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    88436bf View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    94f9b13 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    3a689af View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Configuration menu
    Copy the full SHA
    c115cb6 View commit details
    Browse the repository at this point in the history