Unify Application Signals export template #1430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxaws
approved these changes
Nov 20, 2024
mxiamxia
approved these changes
Nov 21, 2024
lisguo
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Any reason why we are removing eks and k8s yaml configs?
Not sure where the differences were...
There was a problem hiding this comment.
Any reason why we are removing eks and k8s yaml configs?
The appsignals_config_generic.yaml is now identical to eks and k8s yaml configs now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We miss the use case where customers want to send metrics with
RemoteEnvironmentdimension on non Kubernetes based platforms. This PR unifies the template file to allow customers to customize their metrics to addRemoteEnvironment.Description of changes
Unify the EMF export template in Application Signals.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint