-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Disabling Source Type Override Parameters, including Source Version #102
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
431d0f2
Add parameter
khola b56493c
Fix actio ndesc
khola 03fd5f3
Update readme
khola 27aaa1b
Remove console.log
khola 47793a1
Remove readme typo
khola 0487e20
Disable sourceVersion when disableSourceOverride is set
marcus-bcl 9ec1a08
Merge remote-tracking branch 'upstream/master'
marcus-bcl 2919431
Set { required: false } when getting input
marcus-bcl ec9d780
Merge remote-tracking branch 'upstream/main'
marcus-bcl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -152,6 +152,8 @@ async function waitForBuildEndTime( | |
|
||
function githubInputs() { | ||
const projectName = core.getInput("project-name", { required: true }); | ||
const disableSourceOverride = | ||
core.getInput("disable-source-override") === "true"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For consistency, could you either update this new line to use |
||
const { owner, repo } = github.context.repo; | ||
const { payload } = github.context; | ||
// The github.context.sha is evaluated on import. | ||
|
@@ -193,6 +195,7 @@ function githubInputs() { | |
environmentTypeOverride, | ||
imageOverride, | ||
envPassthrough, | ||
disableSourceOverride, | ||
}; | ||
} | ||
|
||
|
@@ -207,10 +210,16 @@ function inputs2Parameters(inputs) { | |
environmentTypeOverride, | ||
imageOverride, | ||
envPassthrough = [], | ||
disableSourceOverride, | ||
} = inputs; | ||
|
||
const sourceTypeOverride = "GITHUB"; | ||
const sourceLocationOverride = `https://github.com/${owner}/${repo}.git`; | ||
const sourceOverride = !disableSourceOverride | ||
? { | ||
sourceVersion: sourceVersion, | ||
sourceTypeOverride: "GITHUB", | ||
sourceLocationOverride: `https://github.com/${owner}/${repo}.git`, | ||
} | ||
: {}; | ||
|
||
const environmentVariablesOverride = Object.entries(process.env) | ||
.filter( | ||
|
@@ -222,9 +231,7 @@ function inputs2Parameters(inputs) { | |
// This way the GitHub events can manage the builds. | ||
return { | ||
projectName, | ||
sourceVersion, | ||
sourceTypeOverride, | ||
sourceLocationOverride, | ||
...sourceOverride, | ||
buildspecOverride, | ||
computeTypeOverride, | ||
environmentTypeOverride, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and
sourceVersion