fix: guard against type errors in prefer-t-regex

avajs · Jan 16, 2023 · fbfd313 · fbfd313
1 parent 40a81b6
commit fbfd313
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/rules/prefer-t-regex.js b/rules/prefer-t-regex.js
@@ -51,7 +51,7 @@ const create = context => {
 	```
 	*/
 	const findRootReference = node => {
-		if (node.type === 'Identifier') {
+		if (node?.type === 'Identifier') {
 			const reference = findReference(node.name);
 
 			if (reference?.init) {
@@ -61,11 +61,11 @@ const create = context => {
 			return node;
 		}
 
-		if (node.type === 'CallExpression' || node.type === 'NewExpression') {
+		if (node?.type === 'CallExpression' || node?.type === 'NewExpression') {
 			return findRootReference(node.callee);
 		}
 
-		if (node.type === 'MemberExpression') {
+		if (node?.type === 'MemberExpression') {
 			return findRootReference(node.object);
 		}
 
@@ -80,19 +80,19 @@ const create = context => {
 	2. `RegExp` class can't be looked up so the function just checks for the name `RegExp`.
 	*/
 	const isRegExp = lookup => {
-		if (lookup.regex) {
+		if (lookup?.regex) {
 			return true;
 		}
 
 		// Look up references in case it's a variable or RegExp declaration.
 		const reference = findRootReference(lookup);
-		return reference.regex ?? reference.name === 'RegExp';
+		return reference?.regex ?? reference?.name === 'RegExp';
 	};
 
 	const booleanHandler = node => {
 		const firstArg = node.arguments[0];
 
-		const isFunctionCall = firstArg.type === 'CallExpression';
+		const isFunctionCall = firstArg?.type === 'CallExpression';
 		if (!isFunctionCall || !firstArg.callee.property) {
 			return;
 		}
@@ -156,7 +156,7 @@ const create = context => {
 		};
 
 		// Only fix a statically verifiable equality.
-		if (regex && matchee.type === 'Literal') {
+		if (regex && matchee?.type === 'Literal') {
 			let assertion;
 
 			if (matchee.raw === 'true') {
@@ -180,7 +180,7 @@ const create = context => {
 			ava.isInTestFile,
 			ava.isInTestNode,
 		])(node => {
-			const isAssertion = node.callee.type === 'MemberExpression'
+			const isAssertion = node.callee?.type === 'MemberExpression'
 				&& util.getNameOfRootNodeObject(node.callee) === 't';
 
 			const isBooleanAssertion = isAssertion

diff --git a/test/prefer-t-regex.js b/test/prefer-t-regex.js
@@ -38,6 +38,9 @@ ruleTester.run('prefer-t-regex', rule, {
 		'test(t => t.true(/\\d+/.test("foo")));',
 		// Not valid, but it shouldn't cause errors
 		'test(t => t.true());',
+		// Not valid, but it shouldn't cause errors
+		header + 'test(t => t.is(true))',
+		header + 'test(t => t.is())',
 	],
 	invalid: [
 		{