Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update banner description #3412

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feat: update banner description #3412

merged 1 commit into from
Nov 19, 2024

Conversation

thulieblack
Copy link
Member

@thulieblack thulieblack commented Nov 19, 2024

Change the ticket button description, to specify that it's free

Summary by CodeRabbit

  • New Features

    • Updated banner text from "Get Your Tickets" to "Get Your Free Ticket" for the AsyncAPI Conference, enhancing user engagement.
  • Bug Fixes

    • No bug fixes were implemented in this release.

Copy link

coderabbitai bot commented Nov 19, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve an update to the cfaText property within the banners array located in the components/campaigns/banners.ts file. The text has been updated from "Get Your Tickets" to "Get Your Free Ticket". The logic of the shouldShowBanner function remains unchanged, which continues to determine the visibility of the banner based on the current date relative to the cfpDeadline.

Changes

File Change Summary
components/campaigns/banners.ts Updated cfaText from "Get Your Tickets" to "Get Your Free Ticket". Logic of shouldShowBanner remains unchanged.

Possibly related PRs

  • feat: create banner for online conf #3312: This PR modifies the cfaText property in the banners array, which is directly related to the change made in the main PR where the cfaText was updated from "Get Your Tickets" to "Get Your Free Ticket".
  • feat: add paris ticket banner  #3363: This PR also updates the banners array and includes changes to the shouldShowBanner function, which is relevant as the main PR's changes occur in the same file and involve the cfaText property.

Suggested reviewers

  • derberg
  • magicmatatjahu
  • anshgoyalevil
  • Mayaleeeee
  • asyncapi-bot-eve
  • devilkiller-ag
  • sambhavgupta0705
  • akshatnema

🐇 In the meadow, banners sway,
"Get Your Free Ticket!" they say.
A change so bright, a message clear,
Hop along, the conference is near!
With joy we bounce, in the sunny light,
Join the fun, it feels just right! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 09f5b8b
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/673c9891c913850008835e0c
😎 Deploy Preview https://deploy-preview-3412--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.77%. Comparing base (6bf75fb) to head (09f5b8b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3412   +/-   ##
=======================================
  Coverage   67.77%   67.77%           
=======================================
  Files          21       21           
  Lines         664      664           
=======================================
  Hits          450      450           
  Misses        214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 32
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3412--asyncapi-website.netlify.app/

@thulieblack
Copy link
Member Author

/ptal

@asyncapi-bot
Copy link
Contributor

@derberg @magicmatatjahu @devilkiller-ag @akshatnema @sambhavgupta0705 @anshgoyalevil @Mayaleeeee Please take a look at this PR. Thanks! 👋

@derberg
Copy link
Member

derberg commented Nov 19, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit bf857b3 into master Nov 19, 2024
28 of 29 checks passed
@asyncapi-bot asyncapi-bot deleted the thulieblack-patch-1 branch November 19, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants