Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved lint warnings #468

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SahilDahekar
Copy link

Description

  • Fixed lint warning in stepThree.js & select.js files.

Related issue(s)

Fixes #328

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 94dcd01
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6741d834b930f6000838e2e5
😎 Deploy Preview https://deploy-preview-468--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind sharing the screenshot of before and after your fix?

@SahilDahekar
Copy link
Author

SahilDahekar commented Nov 13, 2024

Hey @AceTheCreator , here are before and after images :-

Before :
image

After :
image

@AceTheCreator
Copy link
Member

@ashmit-coder your review is needed :)

@ashmit-coder
Copy link
Collaborator

@ashmit-coder your review is needed :)

Hey @AceTheCreator waiting for this pr #386

So that the tests are ran on this pr, just to be sure all functionalities are working.

@SahilDahekar
Copy link
Author

Hey @ashmit-coder , since PR #386 is merged can we proceed with this PR.

@ashmit-coder
Copy link
Collaborator

Hey @ashmit-coder , since PR #386 is merged can we proceed with this PR.

Sure! Soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Resolve the existing Next.js lint issues
3 participants