feat: change navdrop links and sub-links style on hover #463
Conversation
gaurav-2-0-0-2
requested review from
AceTheCreator,
thulieblack,
Mayaleeeee and
ashmit-coder
as code owners
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Awesome enhancement contribution @gaurav-2-0-0-2, but i think a nice addition will be to show which link is currently active. wyt?
Yes I was thinking the same thing. will add changes to this PR |
|
Hey @gaurav-2-0-0-2 The second hover effects for mobile screens would look better as way of indicating where the user is as said by Ace. But I dont see a use of them in mobile view, as after clicking the links the user would simply be redirected. |
do i need to remove package-lock.json when making a PR |
Just dont have any changes in that file |
and the page re renders and the navdrop set to what it was, do we need to highlight the sub menus here or will it be an overkill ? |
|
I don't think it will be an overkill tbh. Wyt @AceTheCreator |
|
Hey, is this enough ? |
Description
Resolves #462
Demo
