Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gallery section to aacot'24 conference website #412

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

techmannih
Copy link
Contributor

close #264
Issue #264

Related issue(s)
Issue #264
@ashmit-coder @Mayaleeeee please review this PR and merge it.
image

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for peaceful-ramanujan-288045 failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit b840ffd
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/670fa70e762ee200087f9fe8

@ashmit-coder
Copy link
Collaborator

@techmannih await for @Mayaleeeee to review the design at first and don't ping reviewers in the pr info.

Secondly please only ping for a single issue once.
We understand if it's been days but if that's not the case atleast wait a day or two before you re-ping members.

@techmannih
Copy link
Contributor Author

okay got it, thank you!

@techmannih
Copy link
Contributor Author

@ashmit-coder please review design

@thulieblack
Copy link
Member

@techmannih please be patient when it comes to PR reviewing. Once you work on a PR allow at least week before reminding the reviewers either here or on Slack

@ashmit-coder
Copy link
Collaborator

@ashmit-coder please review design

Hey @techmannih reviewing of the design is done by @Mayaleeeee and @thulieblack so lets wait for them to get back to you!

@thulieblack
Copy link
Member

@techmannih create a new page container for the gallery section

image

The browse all should direct to that page where all the images are hosted

image

@thulieblack
Copy link
Member

Lastly the events gallery should be the last section on the landing page after tickets

@techmannih
Copy link
Contributor Author

@thulieblack I have added, please review this
image

@ashmit-coder
Copy link
Collaborator

@thulieblack I have added, please review this image

That does not look good in my opinion @techmannih , try to find a way to make it more suitable maybe.

any ideas @thulieblack @AceTheCreator ?

@techmannih
Copy link
Contributor Author

@ashmit-coder please suggest design

@ashmit-coder
Copy link
Collaborator

@ashmit-coder please suggest design

Thats not my area of expertise 😅 but I will suggest something for sure if I think of anything!

@AceTheCreator
Copy link
Member

@techmannih i think you should merge past event under resources hub

@techmannih
Copy link
Contributor Author

techmannih commented Oct 11, 2024

@techmannih i think you should merge past event under resources hub

@thulieblack @AceTheCreator please check
now
image
after adding in resource hub
image

@AceTheCreator
Copy link
Member

@Mayaleeeee, is this how the gallery design should look?

@Mayaleeeee
Copy link
Member

close #264
Issue #264

Related issue(s)
Issue #264
@ashmit-coder @Mayaleeeee please review this PR and merge it.
image

This one?
@AceTheCreator

@techmannih
Copy link
Contributor Author

@thulieblack @AceTheCreator @Mayaleeeee please review this pr

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have more images in bento form instead of 3?
@techmannih

Something like this

Screenshot_20241031_161048_Chrome.jpg

@ashmit-coder
Copy link
Collaborator

cc: @techmannih

@techmannih
Copy link
Contributor Author

Please provide the other images for this design

@ashmit-coder
Copy link
Collaborator

Hey @Mayaleeeee could you assist @techmannih with the design over here, he seems to be lost.

@ashmit-coder
Copy link
Collaborator

Also @techmannih resolve the conflicts.

@techmannih
Copy link
Contributor Author

Also @techmannih resolve the conflicts.

Sure @ashmit-coder

@ashmit-coder
Copy link
Collaborator

Hey @Mayaleeeee could you assist @techmannih with the design over here, he seems to be lost.

cc: @Mayaleeeee

@thulieblack
Copy link
Member

@techmannih please resolve the conflict so we can review

@Mayaleeeee
Copy link
Member

Hey @Mayaleeeee could you assist @techmannih with the design over here, he seems to be lost.

cc: @Mayaleeeee

What design, please?

@techmannih
Copy link
Contributor Author

@techmannih please resolve the conflict so we can review

I thought I would resolve the conflicts in another next commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Gallery Section to AACoT'24 Conference Website
6 participants