feat: handle past events #289
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
remove explicit export from Venue/venue.js
monoMonu
requested review from
AceTheCreator,
thulieblack and
Mayaleeeee
as code owners
@monoMonu, I can't find the design you did. Can you please share the link or a screenshot? Also, the screenshot you provided can't be viewed from my side. |
|
@monoMonu any update on this? |
@Mayaleeeee @AceTheCreator
|
|
@monoMonu please resolve the conflicts |
Done |
|
@monoMonu can you please resolve the conflicts in this pr so we can move forward? |
I have resolved the conflict, please move forward |
I have removed 'upcoming' text |
|
@monoMonu could you please add the final changes to the PR |
There was a problem hiding this comment.
Also, the texts on the ended event cards are not visible @monoMonu
|
@Mayaleeeee @AceTheCreator @thulieblack |
|
cc: @monoMonu |
Done, please merge it |
|
@monoMonu please resolve the conflicts |
|
I guess we should close this pr @AceTheCreator @thulieblack |
|
Resolved the conflict.... |
Description
added a function, which compares the present date and event date to decide the tag for the event (from Upcoming and Ended). Also fades the text color of past events. This is specific to the current format of date used in the cityList.json file.
I tested the code by changing the date of one of the events as you can see...because there were only upcoming events.
removed the "apply to be a speaker" button from the past events as it has no use there.
Related issue(s)
Resolves #208