-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vfs support - ready for full review to merge #16
Open
Buggaboo
wants to merge
144
commits into
asg017:main
Choose a base branch
from
Buggaboo:feature/vfs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in rust, assuming repr(C) will maintain alignment etc.
but most of the coding is done
So the vfs is not loading on sqlite3 it seems to run open and break down on the rusql
unindented unsafe blocks now we have panics due to misalignment when calling Default
docker: cargo build --example mem_vfs ; sqlite3 --init test.sql
and evidently pointer / struct polymorphism is more lenient than I thought
…icult, might Docker be the cause?
… both fail write and truncate tests
…ocate and set_fd to use raw_fd from libc::open instead, it's still flaky freshly created files, still cannot be operated on by liburing
o_write still does not write
1. has support fo fixed file_indices 2, has support for raw fd
Buggaboo
changed the title
vfs support -- testing, not ready to merge, yes to partial review
vfs support - ready to go
Dec 11, 2023
Buggaboo
changed the title
vfs support - ready to go
vfs support - ready for full review to merge
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done!
Please review and consider for merging.