Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace istioctl plugin #466

Merged
merged 1 commit into from
Aug 20, 2021
Merged

fix: replace istioctl plugin #466

merged 1 commit into from
Aug 20, 2021

Conversation

chadlwilson
Copy link
Contributor

@chadlwilson chadlwilson commented Aug 20, 2021

Summary

The current plugin (rafik8's plugin) has been broken on MacOS since at least May 2020 due to inconsistency in whether arch suffixes are included (they generally are not, although there is an arm64 build which currently is not supported).

Attempts have been made to get this fixed, but no response, so the plugin appears to not be actively maintained

By contrast, @virtualstaticvoid 's plugin at https://github.com/virtualstaticvoid/asdf-istioctl is

  • working on MacOS
  • simple shell script
  • has build and tests using the asdf_plugin_test action (here)
  • appears to be actively maintained given response on an issue and commits raised in April 2021.

I suggest we switch the default plugin in the registry to this one.

Checklist

  • CI tests are green. If you are using GitHub, you might want to use the plugin_test action from asdf-actions
  • asdf-plugins CI sanity checks are green on your PullRequest. Test locally with:
./test_plugin.sh --file plugins/<PLUGIN_FILE>

@chadlwilson chadlwilson changed the title Replace unmaintained+broken istioctl plugin with working one fix: replace istioctl plugin with maintained variant working on MacOS Aug 20, 2021
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clearly explaining the history of the current plugin and evidence for it no longer being supported. Saved me a lot of time.

@jthegedus jthegedus changed the title fix: replace istioctl plugin with maintained variant working on MacOS fix: replace istioctl plugin Aug 20, 2021
@jthegedus jthegedus merged commit eea046c into asdf-vm:master Aug 20, 2021
@chadlwilson
Copy link
Contributor Author

Thanks @jthegedus !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants