Convert figure element's xml:id attribute into ID anchor to enable linking to figures #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. I have one request, though. Could you write the anchor as follows? When there is no reftext, we want to encourage the use of the modern, shorthand syntax. I'll also need you to rebase, if possible, since other merges introduced a conflict. Thanks! |
|
@mojavelinux I'll update the syntax and rebase the PR this evening. Should be ready for merging by tomorrow. Thanks for reviewing the PR! |
|
Thanks @fbolton! After that, I'll follow up on your other PRs as well. Thank you for your contributions to improve this converter! |
|
Ping me in a comment when it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, links to figures were broken, because no ID anchor was being generated for figures. This fix extracts the value of the
xml:idattribute from thefigureelement and uses it to generate an anchor,[[XmlId]].