handle equal signs in link element's text (PR #72)

asciidoctor · Oct 12, 2023 · 67bc9c0 · 67bc9c0
1 parent f608398
commit 67bc9c0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/docbookrx/docbook_visitor.rb b/lib/docbookrx/docbook_visitor.rb
@@ -1244,6 +1244,7 @@ def visit_uri node
       if (ref = @attributes.key(url))
         url = %({#{ref}})
       end
+      label = %("#{label.gsub '"', '\\"'}") if label.include? '='
       append_text %(#{prefix}#{url}[#{label}])
     end
     false

diff --git a/spec/lib/docbookrx/docbookrx_spec.rb b/spec/lib/docbookrx/docbookrx_spec.rb
@@ -76,6 +76,18 @@
     expect(output).to include(expected)
   end
 
+  it 'should handle equal signs in link element' do
+    input = <<-EOS
+<para xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">Read about <link xlink:href="http://en.wikipedia.org/wiki/Object-relational_mapping">ORM = Object RM</link> on Wikipedia.</para>
+    EOS
+
+    expected = 'Read about http://en.wikipedia.org/wiki/Object-relational_mapping["ORM = Object RM"] on Wikipedia.'
+
+    output = Docbookrx.convert input
+
+    expect(output).to include(expected)
+  end
+
   it 'should convert uri element to uri macro' do
     input = <<-EOS
 <article xmlns='http://docbook.org/ns/docbook'>