bootscripts: Allwinner: Bugfix: Remove "allwinner/" from 3 boards configurations #7535
+29
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the expected default path to /boot/dtb/allwinner and start analyzing if the DTB file is not found in this path. The folder with the vendor's name is now part of the path, not part of the file name. This greatly facilitates the analysis of various possible options in a simple u-boot shell.
Inform the user about the actual file that will be uploaded on the first iteration. Inform the user that it cannot be downloaded only once if the first iteration was unsuccessful.
In the second iteration, we check the path that does not
contain the vendor folder. But this will also be done if
the real path contains the vendor's folder and the vendor's
name is contained in the DTB file name as
fdtfile=allwinner/sun50i-*-bananapi-*.dtb.
However, overlays will not be available.
Remove "allwinner/" from all board configurations that
use the boot script mechanism so that the script works
correctly.
Signed-off-by: The-going <[email protected]>
Use the DTB name from the u-boot default for the third iteration if the provided DTB name was not found. Also delete the duplicate of the previous iteration.
Make the script work silently when testing path options and report only the actual file being uploaded. Delete the duplicate iteration.
The-going
requested review from
JohnTheCoolingFan,
pyavitz and
igorpecovnik
as code owners
github-actions
bot
added
size/medium
|
2c
|
Yes, it is very desirable. |
What's it? How to deal with it? ===== |
Happens to me as well. #7514 (comment) |
|
Build image and start on board: OK! Test 2: For the DTB file, the error was handled correctly, the kernel loaded, Test 3: OK! Test 4: In the board/sunxi/board.c#L826 file, this is a hard-coded value. I can fix this with a patch, but other users who will use other versions of u-boot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the script for it to work correctly and the three configuration files that use this script.
Remove "allwinner/" from all board configurations that use the boot script mechanism
so that the script works correctly.
Tell the user only the actual actions.
Make the script work silently when testing path options and report only the actual file
being uploaded.
Delete the duplicate iteration.
Inform interested users:
@pyavitz @JohnTheCoolingFan @amazingfate @DGxInfinitY
How Has This Been Tested?
Where the vendor folder does not exist or the DTB file name is incorrect.