Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new device Retroid Pocket RP5 and RPMini #7521

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

tjstyle
Copy link
Contributor

@tjstyle tjstyle commented Nov 28, 2024

Description

Retroid Pocket RP5 and RPMini are Qualcomm SM8250 based device, but since it come with dual boot capability, Booting Android from UFS and also have u-boot that can boot UEFI based OS from MicroSD card slot, so this PR are for building existing SM8250 platform that producing SDCard image instead of ABL type image.

Actually RP5 and RPMini are only different in dtb image used and also slightly different cmdline, so in the future it can be merge to only use 1 config files and use grub boot option to select the device.

How Has This Been Tested?

RP5:

  • ./compile.sh BOARD=retroidpocket-rp5 BRANCH=current RELEASE=noble BUILD_DESKTOP=yes BUILD_MINIMAL=no KERNEL_CONFIGURE=no DESKTOP_APPGROUPS_SELECTED= DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base

RPMini:

  • ./compile.sh BOARD=retroidpocket-rpmini BRANCH=current RELEASE=noble BUILD_DESKTOP=yes BUILD_MINIMAL=no KERNEL_CONFIGURE=no DESKTOP_APPGROUPS_SELECTED= DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base

Peripheral that was working :

  • Display
  • Touchscreen
  • GPU
  • WiFi
  • Bluetooth
  • PWM Fan
  • Gamepad
  • Haptic
  • RGB Led
  • Battery status
  • USB Charging

Only Audio part that still hit and miss, sometime it not detected, but when detected default volume are too loud, so set volume to minimal first before use.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Framework Framework components Patches Patches related to kernel, U-Boot, ... BSP Board Support Packages labels Nov 28, 2024
@amazingfate
Copy link
Contributor

Nice work, I'm going to test the kernel patches on xiaomi-elish.

@tjstyle
Copy link
Contributor Author

tjstyle commented Nov 29, 2024

Nice work, I'm going to test the kernel patches on xiaomi-elish.

Any conflict / regression with this kernel patches?

@amazingfate
Copy link
Contributor

Nice work, I'm going to test the kernel patches on xiaomi-elish.

Any conflict / regression with this kernel patches?

Looks fine. But at the moment dsi panel of xiaomi elish is broken with 6.11.10 kernel. I'm thinking of bumping sm8250-current to 6.12.

Copy link
Contributor

@amazingfate amazingfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm not able to check on xiaomi elish because its dsi panel is broken with 6.11.10, let's merge it. I will include the kernel patches when bumping 6.12.

@tjstyle
Copy link
Contributor Author

tjstyle commented Nov 29, 2024

Although I'm not able to check on xiaomi elish because its dsi panel is broken with 6.11.10, let's merge it. I will include the kernel patches when bumping 6.12.

Actually I have 6.12 tree also, but since in Armbian still use 6.11, so I follow to use that.
For 6.12 here is need modification for SMB5 charger driver, I will update that when you was bump the version.

@amazingfate amazingfate merged commit fd20492 into armbian:main Nov 29, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP Board Support Packages Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

2 participants