Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oras https_proxy issue 7006 and Support CherryBa M1 board #7225

Closed
wants to merge 3 commits into from

Conversation

IsMrX
Copy link
Contributor

@IsMrX IsMrX commented Sep 13, 2024

Description

Commit 1:

If you encounter some network reasons that cause the download speed of resources on github and apt source stations to be very slow or fail, maybe we can use the system network proxy to solve it. The latest version supports the network proxy configured by the system environment variable https_proxy. This commit solves the problem that the https_proxy system network proxy configured by oras pull is not effective.

GitHub issue 7006

Commit 2:

Support CherryBa M1 board
Hardware: allwinner H618 LPDDR4 1G/2G EMMC 8G/16G
Size: 3.52mm*2.82mm
titile

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related like kernel, U-Boot, ... Framework Framework components Patches Patches related to kernel, U-Boot, ... labels Sep 13, 2024
@igorpecovnik
Copy link
Member

I suggest to split PR into two and I think using HTTPS_PROXY or perhaps ORAS_PROXY would be better? No need to export, but suggest passing it as a build parameter, same as others to preserve code styling.

@IsMrX
Copy link
Contributor Author

IsMrX commented Sep 13, 2024

我建议将 PR 一分为二,我认为使用 HTTPS_PROXY 或者 ORAS_PROXY 会更好?无需导出,但建议将其作为 build 参数传递,与其他参数相同,以保留代码样式。

Thank you for your review. I think using it as a build parameter will raise its threshold, because I have met many partners who don't know how to use build parameters. HTTPS_PROXY as a network proxy system environment variable will lower the threshold for use. As mentioned in the issue. His network environment requires the system to mount the proxy in order to happily download apt resources and github resources. In this way, he can solve the problem of slow oras downloads.

@IsMrX IsMrX closed this Sep 13, 2024
@igorpecovnik
Copy link
Member

because I have met many partners who don't know how to use build parameters

./compile.sh PARAMETE1=value PARAMETER2=value ...
https://docs.armbian.com/Developer-Guide_Build-Options/#main-options

ORAS_PROXY is perhaps more suitable?

We are well aware documentation is bad and outdated :( ... we do what we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

2 participants