-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rockchip64 edge kernel to 6.10 #6980
Bump rockchip64 edge kernel to 6.10 #6980
Conversation
* the existing patches for rk3308 audio codec have been disabled: the rk3308 driver has been mainlined and thus the patches don't apply anymore * add the missing i2s_8ch_0 and _1 i2s nodes * adjust "acodec" with "codec" device tree labels, to match mainline kernel nomenclature
1fead2d
to
08df3ae
Compare
@paolosabatino What's worse is that both current and edge have broken audio. I confess, I don't know a lot about the audio subsystem internals. I thinking, at this point, that my priority has to be to get it working again in the "current" kernel. However, I also have reports from users that the 6.9 kernel works! So, if this works, can we make 6.9 "current" for the RockPI-S? |
@igorpecovnik @paolosabatino @rpardini (For my test, I changed the current kernel in rockchip64_common.inc) |
If this is an issue introduced by 6.10, it should be possible to find the commit causing it, by git revert the commits of driver one by one. Then a patch reverting the root cause on 6.10 can fix the issue. |
Hello, I agree with @amazingfate , it is much better to find the cause and patch the thing rather than pinning the kernel on an older version because of a single regression, even though edge kernel for rockchip64 recently moved to 6.12. I spotted also some other regression against rockpi-s in the past with both kernel 6.6 and 6.11 regarding the broken support for realtek 8821cu devices. I can do a round of checks with this newer kernel, I (finally) have a couple of days with some spare time I can invest into. edit: I guess it is a good idea to fix first in kernel 6.6: it will probably be the "current" up to release of the kernel 6.13. When 6.13 will be relesed, the 6.12 (which is supposedly the next LTS version) will become the new "current" and 6.13 will become "edge". I guess it will happen when there is general consesus that 6.12 is good enough to be current, so timing is not strict, but it will happen sooner or later. |
For what it's worth, I agree with @paolosabatino post above. |
I brought up a general clean-up pull request: #7519 - I reworked the disabled patches and now, in my case, analog sound is back |
Description
Bump rockchip64 edge kernel to v6.10.
Includes the rk3328 gpio2 bank fix from #6974
Minor changes have been needed to bring patches from 6.9 to 6.10 (notably, very small rework of the overlay compilation).
@brentr rk3308 now has a mainline audio codec driver. It breaks several patches that previously introduced a driver and manipulated it to "sync with BSP" and convert to "component". This commit contains all the modifications I did to allow the kernel to compile cleanly, but the result may not provide working audio or may not provide the same functionalities as before, hence rk3308 audio section requires some more separate (ie: another pull request) analisys and perhaps some rework.
GitHub issue reference:
Jira reference number AR-2428
How Has This Been Tested?
Checklist: