-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ 🍻 feat(question_eval): Integrate mimoracle dataset to question eval experiments #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some comments on separating the script into smaller methods and also considerations on adding the possibility to replace quickly the dataset we want to use using simple config in hydra
…oad_dataset hf function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the parts I understand, I made a few minor comments
lib/questions_eval/hf_datasets/sub_mimoracle/data/mimoracle_test.csv
Outdated
Show resolved
Hide resolved
lib/questions_eval/hf_datasets/sub_mimoracle/test_mimorable.ipynb
Outdated
Show resolved
Hide resolved
lib/questions_eval/hf_datasets/sub_mimoracle/test_mimorable.ipynb
Outdated
Show resolved
Hide resolved
Co-authored-by: RaphGardies <[email protected]>
Fixes
Fixes #37
Description
This PR does
allergies|history of present illness|past medical history|discharge medications|social history|medications on admission
Technical details
Definition of Done