Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 (Spider): first commit and EDA #2

Merged
merged 1 commit into from
Dec 6, 2023
Merged

🎉 (Spider): first commit and EDA #2

merged 1 commit into from
Dec 6, 2023

Conversation

louni-g
Copy link
Contributor

@louni-g louni-g commented Dec 6, 2023

Description

EDA for the spider dataset

Definition of Done

  • I followed the AI Code Book (I swear!).
  • I have added/updated tests according to my changes.
  • I have added/updated documentation according to my changes.

@louni-g louni-g added the type/feature Introduction of a completely new addition to the codebase label Dec 6, 2023
clementjumel
clementjumel approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@clementjumel clementjumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could have chosen a more a latest pyproject.toml template but it's not a huge deal, other than that looks great!

lib/spider/pyproject.toml Outdated Show resolved Hide resolved
lib/spider/pyproject.toml Outdated Show resolved Hide resolved
@louni-g louni-g merged commit e80f4c7 into main Dec 6, 2023
1 check passed
@louni-g louni-g deleted the lg/spider branch December 11, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clementjumel clementjumel clementjumel approved these changes

@simonmeoni simonmeoni Awaiting requested review from simonmeoni

@svensundell svensundell Awaiting requested review from svensundell

Assignees
No one assigned
Labels
type/feature Introduction of a completely new addition to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louni-g @clementjumel