Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷 Make pre-commit run on all push #11

Merged
merged 1 commit into from
Dec 20, 2023
Merged

👷 Make pre-commit run on all push #11

merged 1 commit into from
Dec 20, 2023

Conversation

clementjumel
Copy link
Contributor

Description

This makes pre-commit run on all push events, not only on main. As a consequence, pre-commit was removed from the PR events, since this would only be duplicates with the push events.

Definition of Done

  • I followed the repository practices (e.g. I used gitmojis).
  • I have added/updated tests according to my changes.
  • I have added/updated documentation according to my changes.

@clementjumel clementjumel added prio/high short (Sugar) It's very short to review! type/improvement Minor improvements not introducing a new feature or requiring a major refactor labels Dec 20, 2023
@clementjumel clementjumel marked this pull request as ready for review December 20, 2023 13:08
ogirardot
ogirardot approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@ogirardot ogirardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clementjumel clementjumel merged commit 94943fb into main Dec 20, 2023
1 check passed
@clementjumel clementjumel deleted the cj/ci branch December 20, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogirardot ogirardot ogirardot approved these changes

Assignees
No one assigned
Labels
prio/high short (Sugar) It's very short to review! type/improvement Minor improvements not introducing a new feature or requiring a major refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clementjumel @ogirardot