This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
feat(app): handle OIDC #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPierrick
reviewed
Apr 21, 2021
app/src/features/User/UserAuth.tsx
Outdated
Comment on lines
61
to
62
| <Button onClick={handleLogout} className={classes.button}> | ||
| <ExitToApp className={classes.icon} /> |
There was a problem hiding this comment.
I think it's better to use the startIcon and endIcon props to add icons to Mui-Buttons
Suggested change
| <Button onClick={handleLogout} className={classes.button}> | |
| <ExitToApp className={classes.icon} /> | |
| <Button | |
| onClick={handleLogout} | |
| className={classes.button} | |
| startIcon={<ExitToApp className={classes.icon} />} | |
| > | |
app/src/features/User/UserAuth.tsx
Outdated
Comment on lines
67
to
72
| <Button | ||
| href={OIDC_LOGIN_URL} | ||
| color="inherit" | ||
| className={classes.button} | ||
| > | ||
| <Launch className={classes.icon} /> |
app/src/features/User/UserRoute.tsx
Outdated
| if (isLoading) return <CircularProgress />; | ||
| if (isAuthenticated) return <Route {...routeProps} />; | ||
|
|
||
| return <Redirect to="/" />; |
There was a problem hiding this comment.
Why not redirect to OIDC_LOGIN_URL ?
BPierrick
approved these changes
Apr 22, 2021
simonvadee
reviewed
Apr 22, 2021
django/river/settings/base.py
Outdated
| @@ -206,7 +206,7 @@ | |||
| # CorsHeaders | |||
| # Used to access api from third-party domain | |||
|
|
|||
| CORS_URLS_REGEX = r"^/api/.*$" | |||
| # CORS_URLS_REGEX = r"^/api/.*$" | |||
There was a problem hiding this comment.
Before cors policies were only applied on host/api but since the oidc routes are on host/oidc, it didn't worked
@vmttn should I remove this or let it commented ?
| @@ -260,6 +260,7 @@ | |||
| OIDC_STORE_ACCESS_TOKEN = True | |||
| # Silently re-authenticated after following time: | |||
| OIDC_RENEW_ID_TOKEN_EXPIRY_SECONDS = int(os.environ.get("OIDC_RENEW_ID_TOKEN_EXPIRY_SECONDS", 12 * 60 * 60)) | |||
| OIDC_TOKEN_USE_BASIC_AUTH = os.environ.get("OIDC_TOKEN_USE_BASIC_AUTH", False) == "True" | |||
There was a problem hiding this comment.
The hydra clients (i'm testing with local-cohort-client) we use have this property "token_endpoint_auth_method": "client_secret_basic",
There was a problem hiding this comment.
Can you add a comment to remember why it's used
vmttn
approved these changes
Apr 22, 2021
simonvadee
approved these changes
Apr 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.