-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Al/new data pr template #13
Open
ALidghi
wants to merge
3
commits into
main
Choose a base branch
from
al/new_data_pr_template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
49 changes: 49 additions & 0 deletions
49
.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE_DATA.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| <!--- | ||
| Provide a short summary in the Title above. Examples of good PR titles: | ||
| * "Feature: add so-and-so models" | ||
| * "Fix: deduplicate such-and-such" | ||
| * "Update: dbt version 0.13.0" | ||
| --> | ||
|
|
||
| ## Description & motivation | ||
| ### Short description | ||
| <!--- | ||
| Describe your changes, and why you're making them. Is this linked to an open | ||
| issue ? Link it here. | ||
| --> | ||
| ### Issue and Author | ||
|
|
||
| Fixes #[issue number] by @[issue author] | ||
|
|
||
| ### Screenshot | ||
| <!--- | ||
| Include a screenshot of the relevant section of the updated DAG. You can access | ||
| your version of the DAG by running `dbt docs generate && dbt docs serve`. | ||
| --> | ||
|
|
||
| ## Data Checklist | ||
| ### Template - New model / Update model | ||
|
|
||
| - [ ] I have written tests on primary keys and it works | ||
| - [ ] I have written tests on foreign keys and it works | ||
| - [ ] I have written the related documentation | ||
| - [ ] I have formatted the model with SQLfmt | ||
| - [ ] I have checked if the model is SQLFLUFF compliant | ||
| - [ ] I have validated the model (dbt run works on my branch) | ||
| - [ ] I have run FHIR validate if needed | ||
|
|
||
|
|
||
| ### Template - Fix model | ||
|
|
||
| - [ ] I have formatted the model with SQLfmt | ||
| - [ ] I have checked if model is SQLFLUFF compliant | ||
| - [ ] I have validated the model (dbt run works on my branch) | ||
| - [ ] I have validated the related tests (Primary key, Foreign key, etc.) | ||
| - [ ] I have run FHIR validate if needed | ||
| - [ ] I have shared this issue with my team (channel data-team) | ||
|
|
||
| ### POST MERGE CHECKLIST | ||
|
|
||
| - [ ] I will remove old tables from the Datalake once I have modified (or deleted) a model name | ||
| - [ ] I will check if dbt run is still working on main | ||
| - [ ] I will check if dbt test is still working on main | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add as below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first part of the template is about creating a new model and not about an issue, that's why we kept this box only in the issue section of the template :)