Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Coverage #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code Coverage #7

wants to merge 2 commits into from

Commits on Apr 26, 2016

  1. Basic code coverage w/ Istanbul for our tests 

    A few problems need to still be solved:
  * Automatically writing the coverage data to a file. As mentioned in
    one of the comments in test/index.html, this can be done with the
    browser file api which is only supported by chrome at the moment, or
    perhaps by using web sockets to send the data back to the server
    which can then write the file to disk.
  * Source maps - currently istanbul's code coverage is based on the
    transpiled typescript, and so does not accurately reflect the
    original code. It's possible to connect the two mentally, but
    difficult. The remap-istanbul project may be of use here.
  * The method of injecting istanbul into the SystemJS module loader is
    a bit of a hack; we can probably make it a cleaner hack by writing a
    SystemJS plugin which we use specifically for loading our files
    during testing.
    DNoved1 authored and DNoved1 committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    5843f39 View commit details
    Browse the repository at this point in the history

  2. Coverage reports now accurately reflect source 

    Aka the previous coverage reports over the transpiled js (from ts) now
have sourcemaps applied to them so that the coverage reports are now
over ts.

Also made coverage reports be automatically written as the tests are
run.
    DNoved1 authored and DNoved1 committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    d61d48d View commit details
    Browse the repository at this point in the history