fix(popover): Fixed extra 4px margin that appears when title is empty #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
flsion
reviewed
May 10, 2024
| @@ -17,7 +17,7 @@ | |||
| > | |||
| <slot /> | |||
| <template #content> | |||
| <div :class="`${prefixCls}-title`"> | |||
| <div v-if="title || titleSlot" :class="`${prefixCls}-title`"> | |||
There was a problem hiding this comment.
arco vue 最初依赖的 vue 3.1 版本还不支持 useSlots，这里从兼容性考虑，可以更换为 v-if="title || $slots.title"
There was a problem hiding this comment.
已经按照要求修改，上次提交忘记提交了样式文件，抱歉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Background and context
修复popover组件的title属性以及slot为空时出现的4px下变局
Solution
判断有无 title 属性和 title slot，如果均没有则隐藏整个 title div
How is the change tested?
Changelog
Checklist:
npm run test)featurebranch and othersshould be submitted to
mainbranch)Other information