Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11664 fix principal user sql #11665

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

bferguso
Copy link
Contributor

@bferguso bferguso commented Dec 3, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Adds a clause to the SQL which updates the principal user, to exclude users that no longer exist in the system.

Issues Solved

Closes #11664

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

Further comments

@bferguso bferguso self-assigned this Dec 3, 2024
@bferguso bferguso added the bug label Dec 3, 2024
@aarongundel
Copy link
Contributor

Unless I'm misunderstanding the intention, looks like this needs to be retargeted to 7.6.x from 8.0.x

@bferguso bferguso changed the base branch from dev/8.0.x to dev/7.6.x December 3, 2024 15:52
@bferguso
Copy link
Contributor Author

bferguso commented Dec 3, 2024

Unless I'm misunderstanding the intention, looks like this needs to be retargeted to 7.6.x from 8.0.x

@aarongundel - Quite right - I'd forgotten to update the target. Correct target selected. Thanks for the catch.

Copy link
Contributor

@aarongundel aarongundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

@bferguso bferguso merged commit 3597bd5 into dev/7.6.x Dec 4, 2024
1 check passed
@bferguso bferguso deleted the 11664_fix_principal_user_sql branch December 4, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10999_update_principaluser migration fails in certain circumstances
2 participants