PE-7099: Staking modal updates #108
Conversation
kunstmusik
commented
Nov 13, 2024
•
kunstmusik
commented
- Add expedited or standard withdrawal selections to initial unstake UI/UX
- Remove EAY from un-staking modal
- Add friction to staking modal (with review modal)
- Add friction to unstaking modal (with review modal)
- Change term unstake to withdraw
|
Visit the preview URL for this PR (updated for commit c569597): https://ar-io-network-portal-a40ee--pr108-pe-7099-staking-moda-ia450k20.web.app (expires Tue, 03 Dec 2024 20:39:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7abfae09c4446982a71cbb94b0cbf4688377a111 |
…s-by-wallet-using-new-sdk-handler' into PE-7099-staking-modal-updates
… to match behavior with adding stake flow
There was a problem hiding this comment.
lucide has this one
There was a problem hiding this comment.
This SVG is from Lucide
There was a problem hiding this comment.
This SVG is from Lucide
There was a problem hiding this comment.
we should make a ticket to get rid of these and use strictly icons from one place as much as possible (ideally) - namely lucide.
There was a problem hiding this comment.
Yeah might be nice to remove the icons from Lucide in the app, add the lucide package, and use those instead. We'll probably still need this index for some custom icons (arconnect, ario.svg, etc.). Will take a bit of time to audit so a separate ticket seems best. (Added PE-7177 for this)
| onSuccess: () => void; | ||
| ticker: string; | ||
| }) => { | ||
| const queryClient = useQueryClient(); |
There was a problem hiding this comment.
Question: whats the difference for us acquiring the current queryClient from the hook vs the constant?
There was a problem hiding this comment.
It's so the components can be reusable across projects and don't depend on a concrete instance.
