feat(PE-7067): release name #594
Open
+299
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atticusofsparta
force-pushed
the
PE-7067-release-name
branch
from
153a1c6
to
b61d898
Compare
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
|
Visit the preview URL for this PR (updated for commit efa393a): https://arns-portal--pr594-pe-7067-release-name-efd42rhj.web.app (expires Tue, 17 Dec 2024 18:11:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f59769442cb89cf2a92042a342e51fe94047b94 |
atticusofsparta
changed the base branch from
develop
to
PE-7154-primary-names
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
kunstmusik
reviewed
Dec 3, 2024
| @@ -35,8 +35,10 @@ | |||
| "no-unused-vars": "off", | |||
| "@typescript-eslint/no-unused-vars": ["error", {}], | |||
| "@typescript-eslint/no-explicit-any": "off", | |||
| "@typescript-eslint/no-non-null-assertion": "off", | |||
There was a problem hiding this comment.
Feels like we're losing some protection here by turning these off.
kunstmusik
reviewed
Dec 3, 2024
| .catch((e: Error) => e); | ||
|
|
||
| if (released instanceof Error) { | ||
| throw new Error('Failed to realease ArNS Name: ' + released.message); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.