Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made navbar uniform across all pages #1630

Closed
wants to merge 0 commits into from

Conversation

shivam8112005
Copy link
Contributor

Title and Issue number

Title :made navbar uniform across all pages

Issue No. : #1626

Code Stack : html, css

Close #1626

Description

This PR standardizes the navbar styling across all pages by ensuring uniform spacing, sizing, and hover effects. It also enhances mobile responsiveness with a cohesive design, improving the overall user experience.

Video/Screenshots (mandatory)

Screenshot 2024-11-06 004758
Screenshot 2024-11-06 004803
Screenshot 2024-11-06 004808

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

github-actions bot commented Nov 5, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@shivam8112005
Copy link
Contributor Author

@apu52 done.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit f1542c1
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6730f2f43bf0c400085f6da9
😎 Deploy Preview https://deploy-preview-1630--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shivam8112005
Copy link
Contributor Author

@apu52 can you please review this?

@apu52 apu52 changed the title made navbar uniform across all pages fix: made navbar uniform across all pages Nov 8, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivam8112005 on many of the pages where u have edited the navbar u have deleted the logo of the website , please try to revert that commit & also whenever I will click on the navbar (like top deals , about etc.)& it will redirect to the other pages but the hamburger is not working well on that pages responsiveness , please try to fix that also

@apu52 apu52 added the help wanted Extra attention is needed label Nov 8, 2024
@shivam8112005
Copy link
Contributor Author

@apu52 ohk

@apu52
Copy link
Owner

apu52 commented Nov 9, 2024

@shivam8112005 have u solves the issue what I have suggested u in the comments?

@shivam8112005
Copy link
Contributor Author

@apu52 Not yet i will do that by 13 currently i am traveling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Navbar styling is not consistent across all pages
2 participants