-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Made navbar Uniform accross all pages #1565
Conversation
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shivam8112005! Thank you for your valuable contribution! Our team will review it and get back to you soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivam8112005 this pr is facing some merge conflicts please try to resolve this so that I can review & merge this pr
@apu52 ohk i will do it by tomorrow |
hey @apu52 now can you merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivam8112005 okkk great
🎉🎉 Thank you for your contribution! Your PR #1565 has been merged! 🎉🎉 |
Title and Issue number
Title :Consistent Navbar Styling across all pages
Issue No. : #1422
Code Stack : html, CSS
Close #1422
Description
The navbar on the homepage and the dedicated-destinations pages shows inconsistencies in:
Font Style: Navbar link fonts differ.
Background Color: Navbar background colors are not uniform.
Logo Font: The logo is not present in dedicate-destinations pages.
Button Alignment: Buttons are misaligned across the dedicate-destinations pages..
Video/Screenshots (mandatory)
Type of PR
Checklist:
contributing.md
file before contributingAdditional context:
##Are you contributing under any Open-source programme?
GSSOC'24 Extended
Hacktoberfest'24