Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add valid email checker while subscribing #1557

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

Ishika-Gupta06
Copy link
Contributor

@Ishika-Gupta06 Ishika-Gupta06 commented Oct 21, 2024

Title : valid Email while Subscribing

Issue No. : #1547

Code Stack : html, JavaScript

Close #1547

Description

improve the regex to ensure the domain part is properly validated (e.g., at least two characters after the dot).
Added an email validation regex (email Pattern) to check the input format.
If the email is valid, the success message is displayed.
If the email is invalid, an error message is displayed for 4 seconds.

Video/Screenshots (mandatory)

Screen.Recording.2024-10-21.175233.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.

  • I have commented my code, particularly in hard-to-understand areas.

  • I have tested the changes thoroughly before submitting this pull request.

  • I have provided relevant issue numbers, screenshots, and videos after making the changes.

  • I have gone through the contributing.md file before contributing

  • I have Starred the Repository.

  • I am contributing under GSSOC'24 Extended

  • I am contributing under Hacktoberfest'24

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit d9eb311
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6716487290b2dc0008b10b99
😎 Deploy Preview https://deploy-preview-1557--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ishika-Gupta06 Ishika-Gupta06 changed the title Add valid email checker while subscribing fix : Add valid email checker while subscribing Oct 21, 2024
@Ishika-Gupta06 Ishika-Gupta06 changed the title fix : Add valid email checker while subscribing fix: Add valid email checker while subscribing Oct 21, 2024
@IRONalways17
Copy link

This pull request includes changes to the index.html file to improve the user experience and validation for the subscription form. The most important changes include adding an error message for invalid email addresses, improving the email validation regex, and refactoring the JavaScript code for better readability and functionality.

User Experience Improvements:

  • Added an error message to notify users when they enter an invalid email address. (index.html index.htmlL1982-R1998)

Validation Enhancements:

Code Refactoring:

  • Refactored JavaScript code to handle form submission more effectively by showing appropriate messages based on email validity. (index.html [1] [2]

@Ishika-Gupta06
Copy link
Contributor Author

@apu52 kindly review the PR

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ishika-Gupta06 good work

@apu52 apu52 merged commit 7e03637 into apu52:main Oct 26, 2024
7 of 10 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #1557 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Check the email format while subscribing
3 participants