-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement multipart streaming for PreloadQuery
#389
Draft
phryneas
wants to merge
12
commits into
pr/framework-explorations
Choose a base branch
from
pr/multipart-streaming
base: pr/framework-explorations
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
changed the title
implement multipart streaming
implement multipart streaming for Nov 13, 2024
PreloadQuery
commit: |
phryneas
commented
Nov 13, 2024
#280 Bundle Size — 1.27MiB (+6.09%).56adfdb(current) vs ef542aa main#274(baseline) Warning Bundle contains 1 duplicate package – View duplicate packages Bundle metrics
|
Current #280 |
Baseline #274 |
|
---|---|---|
Initial JS | 1011.28KiB (+4.47% ) |
968KiB |
Initial CSS | 70B |
70B |
Cache Invalidation | 84.33% |
99.89% |
Chunks | 36 (+5.88% ) |
34 |
Assets | 62 (+5.08% ) |
59 |
Modules | 673 (+6.83% ) |
630 |
Duplicate Modules | 119 (+12.26% ) |
106 |
Duplicate Code | 6.08% (+14.07% ) |
5.33% |
Packages | 26 |
26 |
Duplicate Packages | 1 |
1 |
Bundle size by type 2 changes
2 regressions
Current #280 |
Baseline #274 |
|
---|---|---|
JS | 1.26MiB (+6.06% ) |
1.19MiB |
Other | 10.01KiB (+10.12% ) |
9.09KiB |
CSS | 70B |
70B |
Bundle analysis report Branch pr/multipart-streaming Project dashboard
Generated by RelativeCI Documentation Report issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the happy case (still without
@defer
):https://apollo-git-6cd975-apollo-client-next-package-integration-tests.vercel.app/rsc/dynamic/PreloadQuery/queryRef-useReadQuery
Here we have a simulated error as part of a regular graphql response
https://apollo-git-6cd975-apollo-client-next-package-integration-tests.vercel.app/rsc/dynamic/PreloadQuery/queryRef-useReadQuery?errorIn=rsc
and here we have a link/network error:
https://apollo-git-6cd975-apollo-client-next-package-integration-tests.vercel.app/rsc/dynamic/PreloadQuery/queryRef-useReadQuery?errorIn=rsc,network_error
Adding
@defer
to the mix:https://apollo-git-6cd975-apollo-client-next-package-integration-tests.vercel.app/rsc/dynamic/PreloadQuery/defer-queryRef-useReadQuery