fix: correct conversions for volumes, areas #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quantities used by the
eds.quantitiespipeline had some wrong unit conversions when calling them.Exemples :
Description
The problem is for units whose absolute degree is superior to one (eg m3, m2 etc.). To correct that the
UnitRegistryway of computing the scale is remade withunit_config["scale"] ** abs(unit_config["degree"])(dm3 have now a scale of 0.001 instead of 0.1 previously).The changes also rescale the liter unit such as 1l <=> 1dm3, 1ml <=> 1cm3 and that the scale by 10 between different liter units is kept.
Added tests to check that the pipeline
eds.quantitiescorrectly make conversions.Checklist