chore(deps): cap async_timeout<5.0.0 #31170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
github-actions
bot
removed
github_actions
Some external libraries like langchain are capping async_timeout < 5.0, so aligning with this here, and adding a note for future reference. Also note that regenerating files with `pip-compile-multi` led to removing boto3, which is a good thing, and making that dependency optional in unit tests (will test if it's there, and skip if it isn't)
mistercrunch
force-pushed
the
fix_async_timeout_deps
branch
from
8ffab5f
to
9eb79a0
Compare
sadpandajoe
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some external libraries like langchain are capping async_timeout < 5.0, so aligning with this here, and adding a note for future reference. Also note that regenerating files with
pip-compile-multiled to removing boto3, which is a good thing, and making that dependency optional in unit tests (will test if it's there, and skip if it isn't)