Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oauth2): enable user impersonation by default #30983

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

betodealmeida
Copy link
Member

SUMMARY

When configuring a database, if the user provides OAuth2 client information (ID and secret) then we should automatically enable user impersonation for them.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

WIP

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro
Copy link
Member

Is user impersonation really needed for OAuth? I would have assumed OAuth mostly makes user impersonation redundant, as you already have full user-specific authentication in place (no need for a service account).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants