chore: use playwright to install browsers #30000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
approved these changes
Aug 23, 2024
villebro
reviewed
Aug 23, 2024
Dockerfile
Outdated
Comment on lines
154
to
151
| RUN apt-get update -qq \ | ||
| && apt-get install -yqq --no-install-recommends wget bzip2 \ | ||
| && wget -q https://github.com/mozilla/geckodriver/releases/download/${GECKODRIVER_VERSION}/geckodriver-${GECKODRIVER_VERSION}-linux64.tar.gz -O - | tar xfz - -C /usr/local/bin \ | ||
| # Install Firefox | ||
| && wget -q https://download-installer.cdn.mozilla.net/pub/firefox/releases/${FIREFOX_VERSION}/linux-x86_64/en-US/firefox-${FIREFOX_VERSION}.tar.bz2 -O - | tar xfj - -C /opt \ | ||
| && ln -s /opt/firefox/firefox /usr/local/bin/firefox \ | ||
| && apt-get autoremove -yqq --purge wget bzip2 && rm -rf /var/[log,tmp]/* /tmp/* /var/lib/apt/lists/* | ||
| # Cache everything for dev purposes... | ||
| RUN playwright install chromium --with-deps | ||
| RUN playwright install firefox --with-deps |
There was a problem hiding this comment.
I'm curious, does with work with multiarch builds? I'm assuming the chromium and firefox binaries are different on x86_64 and arm64. It seems previously we were only installing the x86_64 versions.
There was a problem hiding this comment.
@mistercrunch According to the docs, playwright installs the browsers in some local directory, not in usr/local/bin. We can change that with PLAYWRIGHT_BROWSERS_PATH env variable
There was a problem hiding this comment.
There was a problem hiding this comment.
I think cypress installs its own chromium binary. A proper way to test it would be to run a report
|
I meant to write that I haven't tested this and was looking to comment ask for help or instructions as to how to test this. |
mistercrunch
force-pushed
the
playwright-in-docker
branch
2 times, most recently
from
6e25c74
to
019cd50
Compare
mistercrunch
requested review from
geido,
eschutho,
betodealmeida,
nytai,
craig-rueda,
john-bodley and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
mistercrunch
force-pushed
the
playwright-in-docker
branch
from
a5e30ac
to
52a6d84
Compare
github-actions
bot
removed
the
github_actions
github-actions
bot
added
the
github_actions
mistercrunch
force-pushed
the
playwright-in-docker
branch
from
16dffcd
to
6e95418
Compare
github-actions
bot
removed
the
github_actions
mistercrunch
force-pushed
the
playwright-in-docker
branch
from
6e95418
to
6bb8cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems we use playwright to install chromium in some places, but not consistently for chromium and firefox. This makes for confusing/fragile stuff in the Dockerfile. Here I'm just using playwright consistently and in
the docs. Note that this bloats the dev/ci images with BOTH browsers, but people should really just build on top of lean and add their browsers and database drivers from there. We may want to have a single primary browse
r we support and just keep that one in our Dockerfile