fix(dashboard): Dashboard import commands not correctly replacing charts

[lindenh]

SUMMARY

Similar to #22208, the dashboard import commands would not replace charts when the overwrite flag was true, charts would be merged into one dashboard. This change fixes the command in the exact same way as that PR.

Fixes #22127

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

1. Create a dashboard with a chart.
2. Export the dashboard for import later.
3. Modify the dashboard to remove the first chart and add a new one.
4. Import the saved dashboard earlier (via UI OR /api/v1/dashboard/import)
5. Notice both charts are in the dashboard

ADDITIONAL INFORMATION

• Has associated issue: Import dashboard/assets with overwrite flag does not replace dashboards #22127
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[mdeshmu]

Please fix pre-commit by running pre-commit run --all-files

[lindenh]

Done, sorry about that!

[FiiL123]

Is there a plan to have this released anytime soon ? @lindenh @betodealmeida ?

[codecov]

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.45%. Comparing base (76d897e) to head (ae920f5).
Report is 902 commits behind head on master.

Files with missing lines	Patch %	Lines
...perset/commands/dashboard/importers/v1/__init__.py	16.66%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #25102      +/-   ##
==========================================
+ Coverage   60.48%   65.45%   +4.96%     
==========================================
  Files        1931      533    -1398     
  Lines       76236    38609   -37627     
  Branches     8568        0    -8568     
==========================================
- Hits        46114    25271   -20843     
+ Misses      28017    13338   -14679     
+ Partials     2105        0    -2105     

Flag	Coverage Δ
hive	48.96% <16.66%> (-0.20%)	⬇️
javascript	?
presto	53.44% <16.66%> (-0.37%)	⬇️
python	65.45% <16.66%> (+1.96%)	⬆️
unit	60.93% <16.66%> (+3.30%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rusackas]

Is there a plan to have this released anytime soon ? @lindenh @betodealmeida ?

We can't merge it until tests are passing, but hopefully that can happen soon if @lindenh has bandwidth!

[denodo-research-labs]

This affecting us too. We distribute dashboards (with their charts) to different users, and when a user "installs" a new version of a dashboard by importing it with the "overwrite" option, and this new version of the dashboard contains modifications to one or some of the dashboard's charts, those charts are not updated at all.

No need to add or remove charts, just any modifications like changes in the charts' queries will not be performed.

Right now we are asking our users to manually delete the old dashboard plus all its related charts one by one before importing the new version, which is a very inconvenient operation for large dashboards.

[lindenh]

Sorry- I'll fix this right after #30887 gets in. Trying to avoid conflicts made by my own changes.