PROTON-2774: replace CMAKE_SOURCE_DIR variable with PROJECT_SOURCE_DIR
#410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I always wondered why you'd use PROJECT_SOURCE_DIR, now I know! Makes it seem like CMAKE_SOURCE_DIR is usually the wrong thing to use! |
astitcher
approved these changes
Oct 19, 2023
…_DIR` This change allows the CMake build file work as an embedded subproject in an composite CMake build
jiridanek
force-pushed
the
jd_2023_10_14_cmake_subproject_vars
branch
from
caa2db6
to
34c95e2
Compare
|
Even Appveyor passed, it had some infra problems last week and was constantly red then. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the CMake build file work as an embedded subproject in an composite CMake build.